fix best_move selection

- src/NameGame.cc: replace faulty fraction accounting with simple
  std::max_element.

Signed-off-by: Aiden Woodruff <woodra@rpi.edu>

1 files changed, 7 insertions, 6 deletions

diff --git a/src/NameGame.cc b/src/NameGame.cc
index 5b79f87..20221f7 100644
--- a/src/NameGame.cc
+++ b/src/NameGame.cc
@@ -120,12 +120,13 @@ int NameGame::best_move(int nId) const {
                 if (votes.count(v)) votes[v] += 1;
                 else votes[v] = 1;
         }
-        std::map<int, float> fractions;
-        for (auto kv : votes) fractions[kv.first] = kv.second * 1./mem.Len();
-        // Simple majority vote:
-        for (auto kv : fractions)
-                if (kv.second >= 1./mem.Len()) return kv.first;
-        return 0;
+        if (votes.empty()) return 0;
+        int best = std::max_element(votes.begin(), votes.end(),
+                [](const auto& v1, const auto& v2) {
+                        return v1.second < v2.second;
+                }
+        )->first;
+        return best;
 }
 
 void NameGame::update_memory(int nId, int strategy) {